Loading...
Back to Blog
3 things most Salesforce teams miss during code review

3 things most Salesforce teams miss during code review

Lorenzo Frattini

I have been working with dozen of Salesforce teams throughout my career. As I look at how they manage their code reviews, there are 3 things that most of them miss. In this short blog post, I will share them with you.

CRUD/FLS violations

This simply means that the object and field-level security permissions you set can by bypassed. Many believe this is not a big deal for internal Orgs, but it is - especially when you keep sensitive data or when you have external users.

Primary impact: risk of customer data leaks.

Vulnerable third-party JavaScript libraries

Using open source libraries is a great way to accelerate development, but it often comes at the expense of security. Most teams bundle third-party JS in their static resources. When vulnerabilities are discovered for those libraries (it happens all the times) no one notices and the security flaw stays hidden.

Primary impact: code injection vulnerabilities.

Creating data with new in test methods

Not centralising how test objects are created is one of the easiest way to cause rework. All test methods that instantiate sObjects directly via new will break as soon a new validation rule is introduced. Depending on how many tests you have, this could easily cause tens of hours of rework.

Primary impact: regressions.

These problems are sneaky: they require inspecting many files at once, and cannot be detected by tools like PMD, that simply check the syntax of your source files. We have built Clayton to automate these and many more problems out of existence, so you can build more, and worry less.

Share on social media: 

Get ahead.

Join 1000+ Salesforce professionals who receive critical reading, insights and expertise written just for them, from the team at Clayton. Once a week.
Unsubscribe with one click.

More from the Blog

Webinar - Optimize your Apex code with the new Null Coalescing Operator

A 30-minute education session to learn the essential Spring '24 features for Architects and Developers.

Read Story

Watch the Video - The State of Salesforce Development in 2024

Watch the recording of our recent webinar, with Clayton's team and experts from Silverline exploring data and benchmarks for the State of Salesforce Development heading into 2024.

Read Story

Wrapping Up 2023

As we bid farewell to 2023, let's take a moment to look back at the year that just passed. Let's celebrate together by looking back at the favourite features we shipped this year!

Read Story